Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dump_node helper function #5663

Closed
wants to merge 2 commits into from

Conversation

peterfox
Copy link
Contributor

Changes

  • Adds a helper function called dump_node() function
  • Refactors some of the detect node command functionality into a separate service

Why

I've found it difficult when writing new rules at times when I want to just dump the nodes out. Using PHP's var_dump() doesn't work due to recursion. Having the console colours etc. should make it a lot easier to work with.

Let me know if there are further tests that should be worked on. I wasn't sure what to work on.

@samsonasik
Copy link
Member

The dump_node() function was exists, and @TomasVotruba decide to let user use their own choose tool for dumping node, eg, with tracy/tracy, etc.

I will let @TomasVotruba decide if it needs comeback.

@TomasVotruba
Copy link
Member

I'm looking into this... looks interesting 👍

@TomasVotruba
Copy link
Member

Merged in #5696

Thank you @peterfox 🥳

@samsonasik
Copy link
Member

I am closing it as merged at #5696

@samsonasik samsonasik closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants