[Parallel] Fix missing --xdebug in WorkerCommand line on WorkerCommandLineFactory when --xdebug provided #5398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dLineFactory when --xdebug provided
|
I see, the issue was it missing register option to |
|
@TomasVotruba I added unit test on |
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
samsonasik
commented
Dec 28, 2023
| @@ -43,7 +43,7 @@ public function doRun(InputInterface $input, OutputInterface $output): int | |||
| { | |||
| // @fixes https://github.com/rectorphp/rector/issues/2205 | |||
| $isXdebugAllowed = $input->hasParameterOption('--xdebug'); | |||
| if (! $isXdebugAllowed) { | |||
| if ($isXdebugAllowed) { | |||
There was a problem hiding this comment.
by register option xdebug to ProcessConfigureDecorator, the is xdebug has parameter option seems can use truthy check 👍
|
Let's ship it 👍 |
|
in phpstan reecntly the internal worker commands have been marked as hidden, so they don't confuse the end user |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zangai @deviantintegral @MartinsRucevskis @staabm could you verify manually this patch on
WorkerCommandLineFactorycan fix rectorphp/rector#8060Thank you.