Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scoped] Exclude symfony/console/Debug/CliRequest.php from parallel-lint PHP 7.2 syntax check #5304

Merged
merged 3 commits into from Nov 30, 2023
Merged

[Scoped] Exclude symfony/console/Debug/CliRequest.php from parallel-lint PHP 7.2 syntax check #5304

merged 3 commits into from Nov 30, 2023

Conversation

samsonasik
Copy link
Member

@TomasVotruba the symfony/console/Debug/CliRequest.php is under Debug namespace in symfony-console so I think we can just exclude it from parallel-lint check.

Let's give it a try, I rolled back symfony-console dep from:

Fixes rectorphp/rector#8333

@samsonasik samsonasik enabled auto-merge (squash) November 30, 2023 17:59
@samsonasik
Copy link
Member Author

@TomasVotruba let's merge it ;)

@samsonasik samsonasik merged commit 6c81976 into main Nov 30, 2023
41 checks passed
@samsonasik samsonasik deleted the exclude-cli-request branch November 30, 2023 18:00
samsonasik referenced this pull request in easy-coding-standard/easy-coding-standard Dec 2, 2023
@TomasVotruba
lock to console 6.3 to avoid attribute downgrade
1d5901b
@samsonasik samsonasik mentioned this pull request Dec 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@samsonasik