Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Strict] Allow check '0' empty zero on BooleanInTernaryOperatorRuleFixerRector on string type #5297

Merged
merged 8 commits into from Dec 3, 2023
Merged

[Strict] Allow check '0' empty zero on BooleanInTernaryOperatorRuleFixerRector on string type #5297

merged 8 commits into from Dec 3, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Nov 28, 2023 •
edited

@samsonasik samsonasik changed the title [Strict] Allow check 0 empty zero on BooleanInTernaryOperatorRuleFixerRector on string type [Strict] Allow check '0' empty zero on BooleanInTernaryOperatorRuleFixerRector on string type Nov 28, 2023
@samsonasik
Copy link
Member Author

see https://3v4l.org/JraQb

@samsonasik samsonasik marked this pull request as draft November 28, 2023 18:15
@samsonasik samsonasik mentioned this pull request Dec 3, 2023
Closed
@TomasVotruba
Copy link
Member

I see, looks good to me 👍 Can you finish and merge this one?

@samsonasik
Copy link
Member Author

I will try

@samsonasik samsonasik marked this pull request as ready for review December 3, 2023 15:35
@samsonasik
Copy link
Member Author

@staabm @kamil-tekiela @TomasVotruba Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit d9c5d8f into main Dec 3, 2023
41 checks passed
@samsonasik samsonasik deleted the string-empty branch December 3, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@samsonasik @TomasVotruba @actions-user