Remove isPositiveInteger() check for third argument to strpos()

[ikari7789]

Fixes: rectorphp/rector#8303

Removes check that third argument is only a positive integer. Should fix cases where the offset is set dynamically through a variable or expression.

[samsonasik]

More on looking at it, I think dynamic offset should be skipped, to avoid offset changed, eg: on loop which cause invalid changed

[ikari7789]

More on looking at it, I think dynamic offset should be skipped, to avoid offset changed, eg: on loop which cause invalid changed

After I started looking at the code, I think this isn't the right approach to take. The value of the variable here doesn't matter. The previous code was only adding in the offset if the second argument was explicitly an integer. The code now longer cares what the offset is (unless explicitly a zero integer) and sets that directly into place. Even in places where the offset changes, I don't think it should have any impact, unless I'm wildly misunderstanding how this gets processed.

[samsonasik]

I will let @TomasVotruba decide on this.

imo, language features is ok as far as it has safety belt, as old backport to old language will always work.

On dynamic offset usage, it probably make harder to debug when there is a bug caused by its transformation.

[TomasVotruba]

Looks good to me, let's give it a try 👍

[TomasVotruba]

Thank you @ikari7789