UseImportsTraverser: don't deep traverse #4994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Sep 11, 2023
| @@ -77,6 +79,10 @@ private function traverseForType(array $stmts, callable $callable, int $desiredT | |||
| $this->processGroupUse($node, $desiredType, $callable); | |||
| } | |||
|
|
|||
| if (!$node instanceof Namespace_) { | |||
There was a problem hiding this comment.
there are 2 top level node:
Rector\Core\PhpParser\Node\CustomNode\FileWithoutNamespacePhpParser\Node\Stmt\Namespace_
samsonasik
reviewed
Sep 11, 2023
| @@ -77,6 +80,10 @@ private function traverseForType(array $stmts, callable $callable, int $desiredT | |||
| $this->processGroupUse($node, $desiredType, $callable); | |||
| } | |||
|
|
|||
| if (!$node instanceof Namespace_ && !$node instanceof FileWithoutNamespace) { | |||
There was a problem hiding this comment.
How about just use if else if else ?
if ($node instanceof Use_) {
// ...
} elseif ($node instanceof GroupUse) {
// ...
} else {
return NodeTraverser::DONT_TRAVERSE_CHILDREN;
}
return null;
samsonasik
approved these changes
Sep 11, 2023
|
Thank you @staabm |
Merged
This was referenced Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes rectorphp/rector#8194
before in codeigniter4
after
-> 10 % faster