NodeNameResolver: Throw exception in BC breaking path

[staabm]

No description provided.

[staabm]

the failling build tells me we have still some work left in the codebase to compensate the removal of the regex matching ;)

[samsonasik]

@staabm the target code can be updated with:

if (str_contains($name, "*")) {
    fnmatch()...

else
   $this->isName()

[samsonasik]

@staabm please rebase, the fnmatch handling should already covered at PR:

• [CodingStyle] Use str_starts_with() on isName($node, 'test*') on DataProviderArrayItemsNewlinedRector #4988
• [Php55] Check str_contains * before fnmatch() early on StringClassNameToClassConstantRector #4990
• [Transform] Check str_contains * before fnmatch() early on AddAllowDynamicPropertiesAttributeRector #4991

[staabm]

rebased.

[samsonasik]

@staabm please rebase once more :)

[samsonasik]

It seems all green now :)

[samsonasik]

fnmatch should mentioned:

Suggested change

	throw new ShouldNotHappenException('Matching of regular expressions is no longer supported. Use $this->getName() and compare with e.g. str_ends_with() or str_starts_with() instead.');
	throw new ShouldNotHappenException('Matching of regular expressions is no longer supported. Use $this->getName() and compare with e.g. str_ends_with(), str_starts_with(), or fnmatch() instead.');

[samsonasik]

fnmatch example https://3v4l.org/MkqgX

[samsonasik]

hm.., this must be moved in last resort after return strcasecmp($resolvedName, $desiredName) === 0

[TomasVotruba]

I want to exclude fnmatch() on purpose, as it's mostly related to paths, not node names. Also it's pain to use as * works only with specific constant :)

LGTM 👍

[TomasVotruba]

Thank you 👏