[Internals] Decouple output from AbstractRector, narrow debugging output to file path #4976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-post-file-debug
branch
from
bde696a
to
9844dad
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-post-file-debug
branch
from
9844dad
to
efb5972
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-post-file-debug
branch
from
efb5972
to
694bcdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4972
While exploring the collectors, I've noticed the
AbstactRectorhas bloated dependencies that are mixing output and stmts processing. Also, so far the debugged results were not from particular rules, but rather pattern (e.g. regex) used in one of non-Rector services.The goal is to align with https://github.com/phpstan/phpstan-src/tree/1.11.x/src/Analyser, so it's easier to mimic and align features 👍