Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance][Php55] Remove regex replace e on RegexMatcher #4974

Merged
merged 1 commit into from Sep 10, 2023
Merged

[Performance][Php55] Remove regex replace e on RegexMatcher #4974

merged 1 commit into from Sep 10, 2023

Conversation

samsonasik
Copy link
Member

use str_replace() is enough.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit e4eec89 into main Sep 10, 2023
40 checks passed
@samsonasik samsonasik deleted the regex-e branch September 10, 2023 18:59
@TomasVotruba
Copy link
Member

Looks good 🙂 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@samsonasik @TomasVotruba