Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Ensure ArrayType on ReturnTypeFromStrictNewArrayRector::shouldAddReturnArrayDocType() #4932

Merged
merged 1 commit into from Sep 7, 2023
Merged

[TypeDeclaration] Ensure ArrayType on ReturnTypeFromStrictNewArrayRector::shouldAddReturnArrayDocType() #4932

merged 1 commit into from Sep 7, 2023

Conversation

samsonasik
Copy link
Member

Avoid error on unioned array:

         "System error:                                                                                                 
         "Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNewArrayRector::shouldAddReturnArrayDocType():  
         Argument #1 ($arrayType) must be of type PHPStan\Type\ArrayType, PHPStan\Type\UnionType given,

@samsonasik samsonasik enabled auto-merge (squash) September 7, 2023 04:39
@samsonasik samsonasik merged commit eebc3ce into main Sep 7, 2023
40 checks passed
@samsonasik samsonasik deleted the ensure-array branch September 7, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@samsonasik