[TypeDeclaration] Skip return after return closure on AddVoidReturnTypeWhereNoReturnRector

[samsonasik]

@staabm here the following code should be skipped as returns something:

final class SkipReturnAfterClosureReturn
{
    private function run($someObject)
    {
        $someData = $someObject->run('foo', function (): array {
            return [];
        }, strtotime('+6 hours'));

        return $someData[$this->get()];
    }
}

Ref https://getrector.com/demo/1f06cf14-382e-4161-ba39-d2061164ebab

[samsonasik]

@staabm fixed with revert the logic from your PR:

• Faster SilentVoidResolver #4923

as no returns at all need to be checked to return true.

[samsonasik]

@staabm the BetterNodeFinder::findFirstInFunctionLikeScoped() seems needs refactor to ensure find next on scoped search, I created new PR for it to keep using findFirstInFunctionLikeScoped()

• Refactor BetterNodeFinder::findFirstInFunctionLikeScoped() to work with SilentVoidResolver #4931

[staabm]

Good catch