Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Add fallback return direct array support on ReturnTypeFromStrictNewArrayRector #4928

Merged
merged 5 commits into from Sep 6, 2023
Merged

[TypeDeclaration] Add fallback return direct array support on ReturnTypeFromStrictNewArrayRector #4928

merged 5 commits into from Sep 6, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik changed the title [TypeDeclaration] Add fallback return array support on ReturnTypeFromStrictNewArrayRector [TypeDeclaration] Add fallback return direct array support on ReturnTypeFromStrictNewArrayRector Sep 6, 2023
@samsonasik
Copy link
Member Author

implemented 🎉 /cc @staabm

@staabm
Copy link
Contributor

staabm commented Sep 6, 2023

Nice. Does it also support nullable array?
https://getrector.com/demo/c74af6a5-bc6a-479d-8469-cb3a2e56dd5a

@samsonasik
Copy link
Member Author

nullable array = union, that's covered at ReturnUnionTypeRector, see https://getrector.com/demo/8154c1f5-8db4-4a8e-949a-b38b31042c9c

@staabm
Copy link
Contributor

staabm commented Sep 6, 2023

Awesome, thanks

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Member Author

@TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 2a697f7 into main Sep 6, 2023
40 checks passed
@samsonasik samsonasik deleted the fallback-array branch September 6, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@samsonasik @staabm @actions-user