[TypeDeclaration] Add append in loop support on ReturnTypeFromStrictNewArrayRector

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector/Fixture/append_in_loop.php.inc

@@ -0,0 +1,50 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNewArrayRector\Fixture;
+
+final class AppendInLoop
+{
+    public function groupOffers($offers)
+    {
+        $groupOffers = [];
+        $groupedOffers = [];
+
+        foreach ($offers as $offer) {
+            $groupedOffers[$offer->groupid.'--'.$offer->tarifid] = $offer;
+            $groupedOffers[$offer->groupid.'--'.$offer->tarifid]->groupedOffers = $groupOffers;
+        }
+
+        return $groupedOffers;
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNewArrayRector\Fixture;
+
+final class AppendInLoop
+{
+    /**
+     * @return mixed[]
+     */
+    public function groupOffers($offers): array
+    {
+        $groupOffers = [];
+        $groupedOffers = [];
+
+        foreach ($offers as $offer) {
+            $groupedOffers[$offer->groupid.'--'.$offer->tarifid] = $offer;
+            $groupedOffers[$offer->groupid.'--'.$offer->tarifid]->groupedOffers = $groupOffers;
+        }
+
+        return $groupedOffers;
+    }
+}
+
+?>

rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector.php

@@ -121,15 +121,11 @@ public function refactorWithScope(Node $node, Scope $scope): ?Node
             return null;
         }
 
-        $returnType = $this->nodeTypeResolver->getType($onlyReturn->expr);
+        $returnType = $this->nodeTypeResolver->getNativeType($onlyReturn->expr);
         if (! $returnType instanceof ArrayType) {
             return null;
         }
 
-        if (! $this->nodeNameResolver->areNamesEqual($onlyReturn->expr, $variable)) {
-            return null;
-        }
-
         // 3. always returns array
         $node->returnType = new Identifier('array');