ReturnTypeFromStrictTernaryRector: Support complex ternaries

[staabm]

idea is to allow ReturnTypeFromStrictTernaryRector to infer the native return type on complex typed expressions

[staabm]

this test fails to skip right now. If I understood the "strict" rules correctly, they should not rely on phpdoc, right?

if so, any idea how to achieve that?

[samsonasik]

You can compare type vs native type, like in ExprAnalyzer:

rector-src/src/NodeAnalyzer/ExprAnalyzer.php

Lines 42 to 52 in f056974

	$nativeType = $scope->getNativeType($expr);
	if ($nativeType instanceof MixedType && ! $nativeType->isExplicitMixed()) {
	return true;
	}
	$type = $scope->getType($expr);
	if ($nativeType instanceof UnionType) {
	return ! $nativeType->equals($type);
	}
	return ! $nativeType->isSuperTypeOf($type)

[staabm]

thanks. I added a native type check and now I am wondering why ternary_var_call.php.inc is failling.
rector type resolving tells me the native type of the ternary is MixedType but running the same code directly in PHPStan returns a correct native type..

[staabm]

I dropped the failling test for now, as I don't see it important enough to block the actual useful change

[staabm]

before this PR this rector only supported call-methods with a single line.
I wided the scope to call-likes with a single return

[staabm]

should be ready for review/merge @samsonasik

[TomasVotruba]

Looks good, thank you 👍