[AstResolver][Performance] Remove unnecessary double File read on AstResolver::parseFileNameToDecoratedNodes() #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…seFileNameToDecoratedNodes()
samsonasik
changed the title
…seFileNameToDecoratedNodes()
samsonasik
commented
Jul 13, 2023
| @@ -318,9 +316,8 @@ public function parseFileNameToDecoratedNodes(string $fileName): array | |||
| return $this->parsedFileNodes[$fileName] = []; | |||
| } | |||
|
|
|||
| $file = new File($fileName, FileSystem::read($fileName)); | |||
There was a problem hiding this comment.
file already read in previous parse get stmts before, we just need the stmts that already collected in previous line, no need to create new File object and re-read the file, just use the file path and decorate 👍
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.