Exclude the full docs folder from archives #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
previously requested changes
Jul 12, 2023
There was a problem hiding this comment.
docs contains rector rules list overview, so at least that file rector_rules_overview.md need to be kept
https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md
|
I see, it is about including docs in local vendor, I will let @TomasVotruba decide about it 👍 |
|
According to rectorphp/rector#7842 (comment), he seems to be OK about this change though. |
|
Ok, thank you @stof |
|
thanks |
|
Looks good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs rectorphp/rector#7842
The issue also shows unnecessary files in the vendored evenement/evenement package. This will be solved once igorw/evenement#82 is released and the vendored package gets updated.