Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ExplicitMethodCallOverMagicGetSetRector with a protected method #3732

Merged
merged 2 commits into from
May 4, 2023
Merged

Fix ExplicitMethodCallOverMagicGetSetRector with a protected method #3732

merged 2 commits into from
May 4, 2023

Conversation

pierredup
Copy link
Contributor

The ExplicitMethodCallOverMagicGetSetRector changes magic get calls to method calls even though they are not public.

@TomasVotruba
Copy link
Member

Thank you 👍

@TomasVotruba TomasVotruba merged commit 657ec2e into rectorphp:main May 4, 2023
40 checks passed
@pierredup pierredup deleted the protected-method-call branch May 4, 2023 18:21
samsonasik pushed a commit that referenced this pull request May 8, 2023
@pierredup @samsonasik
Fix ExplicitMethodCallOverMagicGetSetRector with a protected method (#…
29f062a 
…3732)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pierredup @TomasVotruba