[TypeDeclaration] Handle infinite loop on array_reverse with index on AddMethodCallBasedStrictParamTypeRector on php8+ feature

packages/PHPStanStaticTypeMapper/TypeMapper/IntegerRangeTypeMapper.php

@@ -0,0 +1,62 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPStanStaticTypeMapper\TypeMapper;
+
+use PhpParser\Node;
+use PhpParser\Node\Identifier;
+use PHPStan\PhpDocParser\Ast\Type\IdentifierTypeNode;
+use PHPStan\PhpDocParser\Ast\Type\TypeNode;
+use PHPStan\Type\IntegerRangeType;
+use PHPStan\Type\Type;
+use Rector\Core\Php\PhpVersionProvider;
+use Rector\Core\ValueObject\PhpVersionFeature;
+use Rector\PHPStanStaticTypeMapper\Contract\TypeMapperInterface;
+
+/**
+ * @implements TypeMapperInterface<IntegerRangeType>
+ */
+final class IntegerRangeTypeMapper implements TypeMapperInterface
+{
+    public function __construct(
+        private readonly PhpVersionProvider $phpVersionProvider
+    ) {
+    }
+
+    /**
+     * @return class-string<Type>
+     */
+    public function getNodeClass(): string
+    {
+        return IntegerRangeType::class;
+    }
+
+    /**
+     * @param IntegerRangeType $type
+     */
+    public function mapToPHPStanPhpDocTypeNode(Type $type, string $typeKind): TypeNode
+    {
+        return new IdentifierTypeNode('int');
+    }
+
+    /**
+     * @param IntegerRangeType $type
+     */
+    public function mapToPhpParserNode(Type $type, string $typeKind): ?Node
+    {
+        if (! $this->phpVersionProvider->isAtLeastPhpVersion(PhpVersionFeature::SCALAR_TYPES)) {
+            return null;
+        }
+
+        if ($type->getMin() === null) {
+            return null;
+        }
+
+        if ($type->getMax() === null) {
+            return null;
+        }
+
+        return new Identifier('int');
+    }
+}

rules-tests/TypeDeclaration/Rector/ClassMethod/AddMethodCallBasedStrictParamTypeRector/Fixture/skip_no_return_array_reverse.php.inc

@@ -0,0 +1,25 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector\Fixture;
+
+final class SkipNoReturnArrayReverse
+{
+    public function run()
+    {
+        $parts = array_reverse(explode('/', '/some/test/url'));
+        foreach ($parts as $index => $uri) {
+            if ($index === 0) {
+                continue;
+            }
+
+            $this->someOtherMethod($index, $uri);
+        }
+    }
+
+    private function someOtherMethod(int $index, string $uri)
+    {
+        return sprintf('%d-%s', $index, $uri);
+    }
+}

rules-tests/TypeDeclaration/Rector/ClassMethod/AddMethodCallBasedStrictParamTypeRector/FixtureUnion/skip_no_return_array_reverse.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector\FixtureUnion;
+
+final class SkipNoReturnArrayReverse
+{
+    public function run()
+    {
+        $parts = array_reverse(explode('/', '/some/test/url'));
+        foreach ($parts as $index => $uri) {
+            if ($index === 0) {
+                continue;
+            }
+
+            $this->someOtherMethod($index, $uri);
+        }
+    }
+
+    private function someOtherMethod(int $index, string $uri)
+    {
+        return sprintf('%d-%s', $index, $uri);
+    }
+}