Simplify PhpFilesFinder #3649
Merged
Simplify PhpFilesFinder #3649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
find-php
branch
2 times, most recently
from
06626d8
to
2478c6f
Compare
staabm
changed the title
| @@ -11,13 +11,4 @@ final class StaticNonPhpFileSuffixes | |||
| */ | |||
| public const SUFFIXES = ['neon', 'yaml', 'xml', 'yml', 'twig', 'latte', 'blade.php', 'tpl']; | |||
There was a problem hiding this comment.
I wonder how is this class needed now. What prevents it from being removed?
There was a problem hiding this comment.
it seems you are fine with dropping this constant and you don't mind BC.
therefore I moved the constant to the last remainig consumer and removed the whole class
staabm
commented
Apr 23, 2023
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't measure any perf difference.
it might result in a perf boost when symfony/symfony#50087 is contained in symfony