Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Php80] Handle crash leaveNode() returned invalid value of type integer on TokenGetAllToObjectRector #3644

Merged
merged 13 commits into from
Apr 21, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Apr 21, 2023

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @nerones

@samsonasik samsonasik marked this pull request as draft April 21, 2023 07:26
@samsonasik
Copy link
Member Author

it seems cause error: Cannot use object of type PhpToken as array

https://3v4l.org/veMeK

$token[0] seems need to be changed to $token->is()

@samsonasik
Copy link
Member Author

Ref https://3v4l.org/Ma0RV

@samsonasik samsonasik marked this pull request as ready for review April 21, 2023 14:40
@samsonasik
Copy link
Member Author

Finally Fixed 🎉

@samsonasik
Copy link
Member Author

Finally 🎉 All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba TomasVotruba merged commit c203b60 into main Apr 21, 2023
39 checks passed
@TomasVotruba TomasVotruba deleted the handle-crash-token branch April 21, 2023 15:23
@TomasVotruba
Copy link
Member

Thank you 👍

samsonasik added a commit that referenced this pull request May 8, 2023
…er on TokenGetAllToObjectRector (#3644)

Co-authored-by: GitHub Action <actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants