Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SingleInArrayToCompareRector if array item is variadic #3640

Merged
merged 3 commits into from Apr 21, 2023
Merged

Fix SingleInArrayToCompareRector if array item is variadic #3640

merged 3 commits into from Apr 21, 2023

Conversation

raoz
Copy link
Contributor

@raoz raoz commented Apr 20, 2023 •
edited by samsonasik

@raoz raoz requested a review from TomasVotruba as a code owner April 20, 2023 15:24
@samsonasik
Copy link
Member

Thank you @raoz

@samsonasik samsonasik merged commit add5582 into rectorphp:main Apr 21, 2023
37 checks passed
samsonasik pushed a commit that referenced this pull request May 8, 2023
@raoz @samsonasik
Fix SingleInArrayToCompareRector if array item is variadic (#3640)
5fcda42 
* Add failing test fixture for SingleInArrayToCompareRector

Based on https://getrector.com/demo/001ae62c-7857-4ce2-b4c1-8be77fd37568

* fix SingleInArrayToCompareRector in case the array item is variadic

* rename SingleInArrayToCompareRector unpacking fixture as suggested by
@samsonasik
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@raoz @samsonasik