Add e2e tests for dry run #3616
Conversation
|
@samsonasik this is the easiest way I found to test that dry run works properly, what do you think? |
|
@samsonasik not ready yet, missed that the 2nd run must use the cache.. |
yguedidi
force-pushed
the
dry-run-e2e-tests
branch
from
1d110f2
to
8244f88
Compare
|
@samsonasik now it works! 🎉 See it makes a broken version of #3614 (same code as #3604) fail that test: https://github.com/rectorphp/rector-src/actions/runs/4704720583/jobs/8344596305?pr=3614 |
| use Rector\DeadCode\Rector\If_\RemoveAlwaysTrueIfConditionRector; | ||
|
|
||
| return static function (RectorConfig $rectorConfig): void { | ||
| $rectorConfig->cacheClass(FileCacheStorage::class); |
There was a problem hiding this comment.
This is the added line to the config from the original e2e/applied-rule-removed-node folder.
It makes the cache persistent between job steps
| // so we can use helper classes here | ||
| require_once __DIR__ . '/../vendor/autoload.php'; | ||
|
|
||
| $e2eCommand = 'php '. $rectorBin .' process --dry-run --no-ansi -a '. $autoloadFile; |
There was a problem hiding this comment.
This runner is a lighter version of the original one, removing the --clear-cache here, and support for custom parameters because they are not needed for now
|
Thank you @yguedidi |
see #3614 (comment)