cleanup RecastingRemovalRector tests

rectorphp · Jul 13, 2023 · e919149 · e919149
1 parent 8346c9b
commit e919149
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 48 deletions.
diff --git a/packages/NodeTypeResolver/NodeTypeResolver.php b/packages/NodeTypeResolver/NodeTypeResolver.php
@@ -147,7 +147,6 @@ public function getType(Node $node): Type
 
         if ($type instanceof Type) {
             $type = $this->accessoryNonEmptyStringTypeCorrector->correct($type);
-
             $type = $this->genericClassStringTypeCorrector->correct($type);
 
             if ($type instanceof ObjectType) {

diff --git a/...sts/DeadCode/Rector/Cast/RecastingRemovalRector/Fixture/non_typed_param_int_check.php.inc b/...sts/DeadCode/Rector/Cast/RecastingRemovalRector/Fixture/non_typed_param_int_check.php.inc
diff --git a/.../DeadCode/Rector/Cast/RecastingRemovalRector/Fixture/skip_non_typed_property.php2.php.inc b/.../DeadCode/Rector/Cast/RecastingRemovalRector/Fixture/skip_non_typed_property.php2.php.inc
@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\DeadCode\Rector\Cast\RecastingRemovalRector\Fixture;
 
-use Rector\Cast\RecastingRemovalRector\Source\ExternalNonStrictTypedProperty;
+use Rector\Tests\DeadCode\Rector\Cast\RecastingRemovalRector\Source\ExternalNonStrictTypedProperty;
 
 final class SkipNonTypedProperty2
 {

diff --git a/rules-tests/DeadCode/Rector/Cast/RecastingRemovalRector/Fixture/some_typed_property.php.inc b/rules-tests/DeadCode/Rector/Cast/RecastingRemovalRector/Fixture/some_typed_property.php.inc
@@ -2,13 +2,13 @@
 
 namespace Rector\Tests\DeadCode\Rector\Cast\RecastingRemovalRector\Fixture;
 
+use Rector\Tests\DeadCode\Rector\Cast\RecastingRemovalRector\Source\ExternalStrictTypedProperty;
+
 final class SomeTypedProperty
 {
-    public int $someProperty = 1;
-
-    public function run()
+    public function run(ExternalStrictTypedProperty $externalStrictTypedProperty)
     {
-        $value = (int) $this->someProperty;
+        $value = (int) $externalStrictTypedProperty->property;
     }
 }
 
@@ -18,13 +18,13 @@ final class SomeTypedProperty
 
 namespace Rector\Tests\DeadCode\Rector\Cast\RecastingRemovalRector\Fixture;
 
+use Rector\Tests\DeadCode\Rector\Cast\RecastingRemovalRector\Source\ExternalStrictTypedProperty;
+
 final class SomeTypedProperty
 {
-    public int $someProperty = 1;
-
-    public function run()
+    public function run(ExternalStrictTypedProperty $externalStrictTypedProperty)
     {
-        $value = $this->someProperty;
+        $value = $externalStrictTypedProperty->property;
     }
 }
 

diff --git a/...sts/DeadCode/Rector/Cast/RecastingRemovalRector/Source/ExternalNonStrictTypedProperty.php b/...sts/DeadCode/Rector/Cast/RecastingRemovalRector/Source/ExternalNonStrictTypedProperty.php
@@ -1,6 +1,8 @@
 <?php
 
-namespace Rector\Cast\RecastingRemovalRector\Source;
+declare(strict_types=1);
+
+namespace Rector\Tests\DeadCode\Rector\Cast\RecastingRemovalRector\Source;
 
 final class ExternalNonStrictTypedProperty
 {

diff --git a/...-tests/DeadCode/Rector/Cast/RecastingRemovalRector/Source/ExternalStrictTypedProperty.php b/...-tests/DeadCode/Rector/Cast/RecastingRemovalRector/Source/ExternalStrictTypedProperty.php
@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DeadCode\Rector\Cast\RecastingRemovalRector\Source;
+
+final class ExternalStrictTypedProperty
+{
+    public int $property = 1;
+}