[TypeDeclaration] Add init assign method call support on ReturnTypeFr…

…omStrictNewArrayRector (#4929)

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector/Fixture/init_assign_method_call.php.inc

@@ -0,0 +1,50 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNewArrayRector\Fixture;
+
+use Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNewArrayRector\Source\OrderRepository;
+
+final class InitAssignMethodCall
+{
+    public function fetchAllForBuyer(OrderRepository $orderRepository)
+    {
+        $orders = $orderRepository->fetchAllForBuyer();
+
+        foreach ($orders as $order) {
+
+        }
+
+        return $orders;
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNewArrayRector\Fixture;
+
+use Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNewArrayRector\Source\OrderRepository;
+
+final class InitAssignMethodCall
+{
+    /**
+     * @return mixed[]
+     */
+    public function fetchAllForBuyer(OrderRepository $orderRepository): array
+    {
+        $orders = $orderRepository->fetchAllForBuyer();
+
+        foreach ($orders as $order) {
+
+        }
+
+        return $orders;
+    }
+}
+
+?>

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector/Source/OrderRepository.php

@@ -0,0 +1,12 @@
+<?php
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNewArrayRector\Source;
+
+final class OrderRepository
+{
+    public function fetchAllForBuyer(): array
+    {
+        return [];
+    }
+}

rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector.php

@@ -234,11 +234,10 @@ private function matchArrayAssignedVariable(array $stmts): Variable|null
                 continue;
             }
 
-            if (! $assign->expr instanceof Array_) {
-                continue;
+            $nativeType = $this->nodeTypeResolver->getNativeType($assign->expr);
+            if ($nativeType->isArray()->yes()) {
+                return $assign->var;
             }
-
-            return $assign->var;
         }
 
         return null;