Improve PropertyFetchAnalyzer performance (#3654)

rectorphp · Apr 22, 2023 · d490fe5 · d490fe5
1 parent f26a476
commit d490fe5
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/NodeAnalyzer/PropertyFetchAnalyzer.php b/src/NodeAnalyzer/PropertyFetchAnalyzer.php
@@ -74,12 +74,15 @@ public function isLocalPropertyFetch(Node $node): bool
 
     public function isLocalPropertyFetchName(Node $node, string $desiredPropertyName): bool
     {
-        if (! $this->isLocalPropertyFetch($node)) {
+        if (! $node instanceof PropertyFetch && ! $node instanceof StaticPropertyFetch) {
+            return false;
+        }
+
+        if (!$this->nodeNameResolver->isName($node->name, $desiredPropertyName)) {
             return false;
         }
 
-        /** @var PropertyFetch|StaticPropertyFetch $node */
-        return $this->nodeNameResolver->isName($node->name, $desiredPropertyName);
+        return $this->isLocalPropertyFetch($node);
     }
 
     public function countLocalPropertyFetchName(Class_ $class, string $propertyName): int