Micro optimizations: cheap checks first (#4510)

rectorphp · Jul 14, 2023 · baa3943 · baa3943
1 parent a12242d
commit baa3943
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/rules/TypeDeclaration/Rector/ClassMethod/ReturnAnnotationIncorrectNullableRector.php b/rules/TypeDeclaration/Rector/ClassMethod/ReturnAnnotationIncorrectNullableRector.php
@@ -83,17 +83,17 @@ public function refactorWithScope(Node $node, Scope $scope): ?Node
     {
         $returnType = $node->getReturnType();
 
+        if ($returnType === null) {
+            return null;
+        }
+
         if ($node instanceof ClassMethod && $this->classMethodReturnTypeOverrideGuard->shouldSkipClassMethod(
             $node,
             $scope
         )) {
             return null;
         }
 
-        if ($returnType === null) {
-            return null;
-        }
-
         if (! $this->phpDocNestedAnnotationGuard->isPhpDocCommentCorrectlyParsed($node)) {
             return null;
         }