AddVoidReturnTypeWhereNoReturnRector: fix never type handling (#4918)

* AddVoidReturnTypeWhereNoReturnRector: added failling tests

* fix

* use native type

* fix PHPStan

* fix

* Update rules-tests/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector/Fixture/exception.php.inc

Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>

* Update rules-tests/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector/Fixture/exception.php.inc

Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>

---------

Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>

rules-tests/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector/Fixture/exception.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+use Rector\Core\Exception\ShouldNotHappenException;
+
+final class ThrowsException
+{
+    public function getValues()
+    {
+        throw new ShouldNotHappenException();
+    }
+}
+-----
+<?php
+
+use Rector\Core\Exception\ShouldNotHappenException;
+
+final class ThrowsException
+{
+    public function getValues(): void
+    {
+        throw new ShouldNotHappenException();
+    }
+}

rules-tests/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector/Fixture/never_method.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector\Fixture;
+
+final class ExitMethod
+{
+    protected function getValues()
+    {
+        exit();
+    }
+}
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector\Fixture;
+
+final class ExitMethod
+{
+    protected function getValues(): void
+    {
+        exit();
+    }
+}

rules-tests/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector/Fixture/throws_method.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector\Fixture;
+
+final class ThrowsMethod
+{
+    protected function getValues()
+    {
+        if (rand(0,1)) {
+            throw new \Exception();
+        }
+
+        echo 'hello world';
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector\Fixture;
+
+final class ThrowsMethod
+{
+    protected function getValues(): void
+    {
+        if (rand(0,1)) {
+            throw new \Exception();
+        }
+
+        echo 'hello world';
+    }
+}
+
+?>

rules/TypeDeclaration/TypeInferer/SilentVoidResolver.php

@@ -26,7 +26,7 @@ final class SilentVoidResolver
 {
     public function __construct(
         private readonly BetterNodeFinder $betterNodeFinder,
-        private readonly ReflectionResolver $reflectionResolver
+        private readonly ReflectionResolver $reflectionResolver,
     ) {
     }
 
@@ -37,10 +37,6 @@ public function hasExclusiveVoid(ClassMethod | Closure | Function_ $functionLike
             return false;
         }
 
-        if ($this->hasNeverType($functionLike)) {
-            return false;
-        }
-
         if ($this->betterNodeFinder->hasInstancesOfInFunctionLikeScoped($functionLike, Yield_::class)) {
             return false;
         }
@@ -134,14 +130,6 @@ private function isTryCatchAlwaysReturn(TryCatch $tryCatch): bool
         return true;
     }
 
-    /**
-     * @see https://phpstan.org/writing-php-code/phpdoc-types#bottom-type
-     */
-    private function hasNeverType(ClassMethod | Closure | Function_ $functionLike): bool
-    {
-        return $this->betterNodeFinder->hasInstancesOf($functionLike, [Throw_::class]);
-    }
-
     private function resolveReturnCount(Switch_ $switch): int
     {
         $casesWithReturnCount = 0;