[Performance] Using cheap chekc first on UndefinedVariableResolver::s…

…houldSkipVariable() (#3643)
rectorphp · Apr 21, 2023 · ae99f13 · ae99f13
1 parent 79a6309
commit ae99f13
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/rules/Php56/NodeAnalyzer/UndefinedVariableResolver.php b/rules/Php56/NodeAnalyzer/UndefinedVariableResolver.php
@@ -146,10 +146,6 @@ private function shouldSkipVariable(Variable $variable, Node $parentNode): bool
             return true;
         }
 
-        if ($this->variableAnalyzer->isStaticOrGlobal($variable)) {
-            return true;
-        }
-
         if ($this->isAssign($parentNode)) {
             return true;
         }
@@ -163,10 +159,6 @@ private function shouldSkipVariable(Variable $variable, Node $parentNode): bool
             return true;
         }
 
-        if ($this->isDifferentWithOriginalNodeOrNoScope($variable)) {
-            return true;
-        }
-
         $variableName = $this->nodeNameResolver->getName($variable);
 
         // skip $this, as probably in outer scope
@@ -178,6 +170,14 @@ private function shouldSkipVariable(Variable $variable, Node $parentNode): bool
             return true;
         }
 
+        if ($this->isDifferentWithOriginalNodeOrNoScope($variable)) {
+            return true;
+        }
+
+        if ($this->variableAnalyzer->isStaticOrGlobal($variable)) {
+            return true;
+        }
+
         if ($this->hasPreviousCheckedWithIsset($variable)) {
             return true;
         }