Improve ReflectionResolver performance (#3658)

rectorphp · May 8, 2023 · a309aa6 · a309aa6
1 parent 6456123
commit a309aa6
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/Reflection/ReflectionResolver.php b/src/Reflection/ReflectionResolver.php
@@ -219,6 +219,11 @@ public function resolveMethodReflectionFromNew(New_ $new): ?MethodReflection
     public function resolvePropertyReflectionFromPropertyFetch(
         PropertyFetch | StaticPropertyFetch $propertyFetch
     ): ?PhpPropertyReflection {
+        $propertyName = $this->nodeNameResolver->getName($propertyFetch->name);
+        if ($propertyName === null) {
+            return null;
+        }
+
         $fetcheeType = $propertyFetch instanceof PropertyFetch
             ? $this->nodeTypeResolver->getType($propertyFetch->var)
             : $this->nodeTypeResolver->getType($propertyFetch->class);
@@ -233,11 +238,6 @@ public function resolvePropertyReflectionFromPropertyFetch(
 
         $classReflection = $this->reflectionProvider->getClass($fetcheeType->getClassName());
 
-        $propertyName = $this->nodeNameResolver->getName($propertyFetch->name);
-        if ($propertyName === null) {
-            return null;
-        }
-
         if (! $classReflection->hasProperty($propertyName)) {
             return null;
         }