Prevent unnecessary calls to spl_object_id() (#4992)

rectorphp · Sep 11, 2023 · 8b8a0d1 · 8b8a0d1
1 parent b261756
commit 8b8a0d1
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/packages/PhpDocParser/NodeVisitor/CallableNodeVisitor.php b/packages/PhpDocParser/NodeVisitor/CallableNodeVisitor.php
@@ -51,7 +51,9 @@ public function enterNode(Node $node): int|Node|null
 
     public function leaveNode(Node $node): int|Node
     {
-        if ($this->nodeIdToRemove === spl_object_id($node)) {
+        if ($this->nodeIdToRemove !== null
+            && $this->nodeIdToRemove === spl_object_id($node)
+        ) {
             $this->nodeIdToRemove = null;
             return NodeTraverser::REMOVE_NODE;
         }