[NodeTypeResolver] Remove AttributeKey::IS_RETURN_EXPR from ContextNo…

…deVisitor (#4502) Co-authored-by: GitHub Action <actions@github.com>
rectorphp · Jul 13, 2023 · 898d599 · 898d599
1 parent a10ddea
commit 898d599
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/packages/NodeTypeResolver/Node/AttributeKey.php b/packages/NodeTypeResolver/Node/AttributeKey.php
@@ -292,11 +292,6 @@ final class AttributeKey
      */
     public const IS_NEW_INSTANCE_NAME = 'is_new_instance_name';
 
-    /**
-     * @var string
-     */
-    public const IS_RETURN_EXPR = 'is_return_expr';
-
     /**
      * @var string
      */

diff --git a/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/ContextNodeVisitor.php b/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/ContextNodeVisitor.php
@@ -7,7 +7,6 @@
 use PhpParser\Node;
 use PhpParser\Node\Arg;
 use PhpParser\Node\Attribute;
-use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\Array_;
 use PhpParser\Node\Expr\ArrayDimFetch;
 use PhpParser\Node\Expr\Closure;
@@ -26,7 +25,6 @@
 use PhpParser\Node\Stmt\Foreach_;
 use PhpParser\Node\Stmt\Function_;
 use PhpParser\Node\Stmt\If_;
-use PhpParser\Node\Stmt\Return_;
 use PhpParser\Node\Stmt\Unset_;
 use PhpParser\Node\Stmt\While_;
 use PhpParser\NodeTraverser;
@@ -69,11 +67,6 @@ public function enterNode(Node $node): ?Node
             return null;
         }
 
-        if ($node instanceof Return_ && $node->expr instanceof Expr) {
-            $node->expr->setAttribute(AttributeKey::IS_RETURN_EXPR, true);
-            return null;
-        }
-
         if ($node instanceof Arg) {
             $node->value->setAttribute(AttributeKey::IS_ARG_VALUE, true);
             return null;