[TypeDeclaration] Handle infinite loop on array_reverse with index on…

… AddMethodCallBasedStrictParamTypeRector on php8+ feature (#3678)

* [TypeDeclaration] Handle infinite loop on array_reverse with index

* [ci-review] Rector Rectify

* add fixture for php7.4 as well

* fix namespace

* [ci-review] Rector Rectify

* Fix

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>

rules-tests/TypeDeclaration/Rector/ClassMethod/AddMethodCallBasedStrictParamTypeRector/Fixture/skip_no_return_array_reverse.php.inc

@@ -0,0 +1,25 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector\Fixture;
+
+final class SkipNoReturnArrayReverse
+{
+    public function run()
+    {
+        $parts = array_reverse(explode('/', '/some/test/url'));
+        foreach ($parts as $index => $uri) {
+            if ($index === 0) {
+                continue;
+            }
+
+            $this->someOtherMethod($index, $uri);
+        }
+    }
+
+    private function someOtherMethod(int $index, string $uri)
+    {
+        return sprintf('%d-%s', $index, $uri);
+    }
+}

rules-tests/TypeDeclaration/Rector/ClassMethod/AddMethodCallBasedStrictParamTypeRector/FixtureUnion/skip_no_return_array_reverse.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector\FixtureUnion;
+
+final class SkipNoReturnArrayReverse
+{
+    public function run()
+    {
+        $parts = array_reverse(explode('/', '/some/test/url'));
+        foreach ($parts as $index => $uri) {
+            if ($index === 0) {
+                continue;
+            }
+
+            $this->someOtherMethod($index, $uri);
+        }
+    }
+
+    private function someOtherMethod(int $index, string $uri)
+    {
+        return sprintf('%d-%s', $index, $uri);
+    }
+}

rules/TypeDeclaration/NodeAnalyzer/ClassMethodParamTypeCompleter.php

@@ -38,8 +38,13 @@ public function __construct(
     public function complete(ClassMethod $classMethod, array $classParameterTypes, int $maxUnionTypes): ?ClassMethod
     {
         $hasChanged = false;
+        $totalTypes = count($classParameterTypes);
 
         foreach ($classParameterTypes as $position => $argumentStaticType) {
+            if ($totalTypes > 1 && $argumentStaticType instanceof UnionType) {
+                return null;
+            }
+
             /** @var Type $argumentStaticType */
             if ($this->shouldSkipArgumentStaticType($classMethod, $argumentStaticType, $position, $maxUnionTypes)) {
                 continue;