[CodeQuality] Skip call parent::__construct() indirect parent on ConstructClassMethodToSetUpTestCaseRector #251

samsonasik · 2023-09-10T01:25:43Z

Continue of PR:

[NodeAnalyzer] Fix crash on set returnType on setUp() method on ConstructClassMethodToSetUpTestCaseRector #250

this ensure when there is parent::__construct() call on indirect parent, it should be skipped as indirect use.

…ToSetUpTestCaseRector

samsonasik · 2023-09-10T01:30:28Z

Init early should also be skipped:

final class SkipParameterUsed extends TestCase
{
    public function __construct($param)
    {
        $this->initEarly($param);
    }

    private function initEarly($param)
    {
        echo 'init';
    }
}

It currently cause invalid result:

 final class SkipParameterUsed extends TestCase
 {
-    public function __construct($param)
+    protected function setUp()
     {
         $this->initEarly($param);

which param removed but used in the caller.

samsonasik · 2023-09-10T01:32:31Z

phpunit.xml

@@ -8,6 +8,7 @@
    <testsuites>
        <testsuite name="main">
            <directory>tests</directory>
+            <directory>rules-tests</directory>


@TomasVotruba here rules-tests need to be registered to show the PHPUnit error, it was never executed.

Damn, that's a big miss from my side 🤦 😅

samsonasik · 2023-09-10T01:36:00Z

15 errors because rules-tests was never executed #251 (review)

Run vendor/bin/phpunit
  vendor/bin/phpunit
  shell: /usr/bin/bash -e {0}
  env:
    COMPOSER_ROOT_VERSION: dev-main
    COMPOSER_PROCESS_TIMEOUT: 0
    COMPOSER_NO_INTERACTION: 1
    COMPOSER_NO_AUDIT: 1
PHPUnit 10.3.3 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.23
Configuration: /home/runner/work/rector-phpunit/rector-phpunit/phpunit.xml

..................FFF.......F.F.........FF.FF..................  63 / 195 ( 32%)
...............F............F.................................. 126 / 195 ( 64%)
F..........................................FFF................. 189 / 195 ( 96%)
......                                                          195 / 195 (100%)

Time: 00:03.898, Memory: 146.50 MB

There were 4 PHPUnit test runner warnings:

1) No tests found in class "Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\ClassMethod\DependsAnnotationWithValueToAttributeRector\Source\AnotherTest".

2) Class DifferentNamespaceTest cannot be found in /home/runner/work/rector-phpunit/rector-phpunit/rules-tests/CodeQuality/Rector/Class_/AddSeeTestAnnotationRector/Source/DifferentNamespaceTest.php

3) Class SkipSimpleClassCommentTest cannot be found in /home/runner/work/rector-phpunit/rector-phpunit/rules-tests/CodeQuality/Rector/Class_/AddSeeTestAnnotationRector/Source/SkipSimpleClassCommentTest.php

4) Class SomeExistingTest cannot be found in /home/runner/work/rector-phpunit/rector-phpunit/rules-tests/CodeQuality/Rector/Class_/AddSeeTestAnnotationRector/Source/SomeExistingTest.php

--

There were 15 failures:

1) Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\ClassMethod\TestWithAnnotationToAttributeRector\TestWithAnnotationToAttributeRectorTest::test with data set #0
Failed on fixture file "some_fixture.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 
 final class SomeFixture extends TestCase
 {
-    #[\PHPUnit\Framework\Attributes\TestWith(['foo'])]
-    #[\PHPUnit\Framework\Attributes\TestWith(['bar'])]
+    /**
+     * @testWith ["foo"]
+     *           ["bar"]
+     */
     public function testOne(): void
     {
     }

/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:245
/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:169
/home/runner/work/rector-phpunit/rector-phpunit/rules-tests/AnnotationsToAttributes/Rector/ClassMethod/TestWithAnnotationToAttributeRector/TestWithAnnotationToAttributeRectorTest.php:16

2) Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\ClassMethod\TestWithAnnotationToAttributeRector\TestWithAnnotationToAttributeRectorTest::test with data set #1
Failed on fixture file "some_lower_cased.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 
 final class SomeLowerCased extends TestCase
 {
-    #[\PHPUnit\Framework\Attributes\TestWith(['rum'])]
-    #[\PHPUnit\Framework\Attributes\TestWith(['fim'])]
+    /**
+     * @testwith ["rum"]
+     * @testwith    ["fim"]
+     */
     public function testOne(): void
     {
     }

/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:245
/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:169
/home/runner/work/rector-phpunit/rector-phpunit/rules-tests/AnnotationsToAttributes/Rector/ClassMethod/TestWithAnnotationToAttributeRector/TestWithAnnotationToAttributeRectorTest.php:16

3) Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\ClassMethod\TestWithAnnotationToAttributeRector\TestWithAnnotationToAttributeRectorTest::test with data set #2
Failed on fixture file "the_most_complex_json.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 
 final class TheMostComplexJson extends TestCase
 {
-    #[\PHPUnit\Framework\Attributes\TestWith([['day' => 'monday', 'conditions' => 'sunny'], ['day', 'conditions']])]
+    /**
+     * @testWith [{"day": "monday", "conditions": "sunny"}, ["day", "conditions"]]
+     */
      public function testOne(): void
      {
      }

/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:245
/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:169
/home/runner/work/rector-phpunit/rector-phpunit/rules-tests/AnnotationsToAttributes/Rector/ClassMethod/TestWithAnnotationToAttributeRector/TestWithAnnotationToAttributeRectorTest.php:16

4) Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\RemoveEmptyTestMethodRector\RemoveEmptyTestMethodRectorTest::test with data set #0
Failed on fixture file "fixture.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 
 class SomeTest extends \PHPUnit\Framework\TestCase
 {
+    /**
+     * testGetTranslatedModelField method
+     *
+     * @return void
+     */
+    public function testGetTranslatedModelField()
+    {
+    }
 }
 
 ?>

/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:245
/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:169
/home/runner/work/rector-phpunit/rector-phpunit/rules-tests/CodeQuality/Rector/ClassMethod/RemoveEmptyTestMethodRector/RemoveEmptyTestMethodRectorTest.php:16

5) Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\ReplaceTestAnnotationWithPrefixedFunctionRector\ReplaceTestAnnotationWithPrefixedFunctionRectorTest::test with data set #1
Failed on fixture file "skip_already_prefixed_function.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 
 class SkipAlreadyPrefixedFunction extends \PHPUnit\Framework\TestCase
 {
-    /**
-     * @test
-     */
-    public function testOnePlusOneShouldBeTwo()
+    public function testTestOnePlusOneShouldBeTwo()
     {
         $this->assertSame(2, 1+1);
     }

/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:245
/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:169
/home/runner/work/rector-phpunit/rector-phpunit/rules-tests/CodeQuality/Rector/ClassMethod/ReplaceTestAnnotationWithPrefixedFunctionRector/ReplaceTestAnnotationWithPrefixedFunctionRectorTest.php:16

6) Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\ConstructClassMethodToSetUpTestCaseRector\ConstructClassMethodToSetUpTestCaseRectorTest::test with data set #2
Failed on fixture file "skip_call_parent_construct.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 {
     private $someValue;
 
-    public function __construct()
+    protected function setUp()
     {
         $this->someValue = 1000;
-
-        parent::__construct();
     }
 }

/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:245
/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:169
/home/runner/work/rector-phpunit/rector-phpunit/rules-tests/CodeQuality/Rector/Class_/ConstructClassMethodToSetUpTestCaseRector/ConstructClassMethodToSetUpTestCaseRectorTest.php:16

7) Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\ConstructClassMethodToSetUpTestCaseRector\ConstructClassMethodToSetUpTestCaseRectorTest::test with data set #3
Failed on fixture file "skip_parameter_used.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 
 final class SkipParameterUsed extends TestCase
 {
-    public function __construct($param)
+    protected function setUp()
     {
         $this->initEarly($param);
     }

/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:245
/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:169
/home/runner/work/rector-phpunit/rector-phpunit/rules-tests/CodeQuality/Rector/Class_/ConstructClassMethodToSetUpTestCaseRector/ConstructClassMethodToSetUpTestCaseRectorTest.php:16

8) Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\PreferPHPUnitThisCallRector\PreferPHPUnitThisCallRectorTest::test with data set #0
Failed on fixture file "replace_none_static_skip_static_function.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 {
     public function testMe()
     {
-        $this->assertSame(1, 1);
+        self::assertSame(1, 1);
     }
 
     public static function testMe2()

/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:245
/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:169
/home/runner/work/rector-phpunit/rector-phpunit/rules-tests/CodeQuality/Rector/Class_/PreferPHPUnitThisCallRector/PreferPHPUnitThisCallRectorTest.php:16

9) Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\PreferPHPUnitThisCallRector\PreferPHPUnitThisCallRectorTest::test with data set #1
Failed on fixture file "short_classes.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 {
     public function testMe()
     {
-        $this->assertSame(1, 1);
+        self::assertSame(1, 1);
     }
 }

/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:245
/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:169
/home/runner/work/rector-phpunit/rector-phpunit/rules-tests/CodeQuality/Rector/Class_/PreferPHPUnitThisCallRector/PreferPHPUnitThisCallRectorTest.php:16

10) Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertIssetToSpecificMethodRector\AssertIssetToSpecificMethodRectorTest::test with data set #3
Failed on fixture file "skip_if_magic_method_isset_exists_in_parent.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
     public function test()
     {
         $foo = new \Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertIssetToSpecificMethodRector\Fixture\CustomIsset2();
-        $this->assertObjectHasAttribute('bar', $foo);
+        $this->assertTrue(isset($foo->bar));
     }
 }

/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:245
/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:169
/home/runner/work/rector-phpunit/rector-phpunit/rules-tests/CodeQuality/Rector/MethodCall/AssertIssetToSpecificMethodRector/AssertIssetToSpecificMethodRectorTest.php:16

11) Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertTrueFalseToSpecificMethodRector\AssertTrueFalseToSpecificMethodRectorTest::test with data set #3
Failed on fixture file "fixture.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
         $this->assertContains('...', ['...'], 'argument');
 
         $this->assertNotIsReadable('...');
-        $this->assertEmpty('...');
+        $this->assertTrue(empty('...'));
         $this->assertFileNotExists('...');
         $this->assertDirectoryExists('...');
         $this->assertFinite('...');

/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:245
/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:169
/home/runner/work/rector-phpunit/rector-phpunit/rules-tests/CodeQuality/Rector/MethodCall/AssertTrueFalseToSpecificMethodRector/AssertTrueFalseToSpecificMethodRectorTest.php:16

12) Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\AddDoesNotPerformAssertionToNonAssertingTestRectorTest::test with data set #0
Failed on fixture file "fixture.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 
 class SomeClass extends \PHPUnit\Framework\TestCase
 {
-    /**
-     * @doesNotPerformAssertions
-     */
     public function test()
     {
         $nothing = 5;

/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:245
/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:169
/home/runner/work/rector-phpunit/rector-phpunit/rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/AddDoesNotPerformAssertionToNonAssertingTestRectorTest.php:16

13) Rector\PHPUnit\Tests\PHPUnit70\Rector\Class_\RemoveDataProviderTestPrefixRector\RemoveDataProviderTestPrefixRectorTest::test with data set #0
Failed on fixture file "fixture.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
         $nothing = 5;
     }
 
-    public function provideData()
+    public function testProvideData()
     {
         return ['123'];
     }

/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:245
/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:169
/home/runner/work/rector-phpunit/rector-phpunit/rules-tests/PHPUnit70/Rector/Class_/RemoveDataProviderTestPrefixRector/RemoveDataProviderTestPrefixRectorTest.php:16

14) Rector\PHPUnit\Tests\PHPUnit70\Rector\Class_\RemoveDataProviderTestPrefixRector\RemoveDataProviderTestPrefixRectorTest::test with data set #1
Failed on fixture file "multiple_data_providers.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
         $nothing = 5;
     }
 
-    public function provideData()
+    public function testProvideData()
     {
         return ['123'];
     }
 
-    public function nextProvideData2()
+    public function testNextProvideData2()
     {
         return ['123'];
     }
 
-    public function nextProvideData()
+    public function testNextProvideData()
     {
         return ['123'];
     }

/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:245
/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:169
/home/runner/work/rector-phpunit/rector-phpunit/rules-tests/PHPUnit70/Rector/Class_/RemoveDataProviderTestPrefixRector/RemoveDataProviderTestPrefixRectorTest.php:16

15) Rector\PHPUnit\Tests\PHPUnit70\Rector\Class_\RemoveDataProviderTestPrefixRector\RemoveDataProviderTestPrefixRectorTest::test with data set #2
Failed on fixture file "with_test_annotation.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
         $nothing = 5;
     }
 
-    public function provideDataForWithATestAnnotation()
+    public function testProvideDataForWithATestAnnotation()
     {
         return ['123'];
     }

/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:245
/home/runner/work/rector-phpunit/rector-phpunit/vendor/rector/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:169
/home/runner/work/rector-phpunit/rector-phpunit/rules-tests/PHPUnit70/Rector/Class_/RemoveDataProviderTestPrefixRector/RemoveDataProviderTestPrefixRectorTest.php:16

FAILURES!
Tests: 195, Assertions: 261, Failures: 15, Warnings: 4.

samsonasik · 2023-09-10T01:46:16Z

@TomasVotruba @staabm the errors seems due to remove regex support:

[Naming] Remove matchesStringName() check completely from NodeNameResolver, including endsWith() method - use getName() and compare directly instead rector-src#4954
BC: Separated regex matching in NodeNameResolver->isName() rector-src#4951

which make the following code no longer works:

rector-phpunit/rules/CodeQuality/Rector/Class_/PreferPHPUnitThisCallRector.php

Lines 97 to 99 in 2800f5c

    
           if (! $this->isName($node->name, 'assert*')) { 
        
               return null; 
        
           }

The error detected after rules-tests registered to phpunit.xml above

#251 (review)

rules/CodeQuality/Rector/Class_/PreferPHPUnitThisCallRector.php

samsonasik · 2023-09-10T02:14:39Z

rules/CodeQuality/Rector/ClassMethod/ReplaceTestAnnotationWithPrefixedFunctionRector.php

@@ -71,7 +72,7 @@ public function refactor(Node $node): ?Node
            return null;
        }

-        if ($this->isName($node->name, 'test*')) {
+        if (fnmatch('test*', $node->name->toString(), FNM_NOESCAPE)) {


@TomasVotruba @staabm using fnmatch() directly seems the solution

samsonasik · 2023-09-10T02:32:52Z

src/NodeAnalyzer/AssertCallAnalyzer.php

+        ] as $methodCallNamePattern) {
+            if (fnmatch($methodCallNamePattern, $callname, FNM_NOESCAPE)) {
+                return true;
+            }
+        }


@TomasVotruba @staabm here the tweak fnmatch in loop :)

samsonasik · 2023-09-10T02:56:42Z

Fixed 🎉

samsonasik · 2023-09-10T03:12:19Z

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

samsonasik · 2023-09-10T05:21:33Z

rules/CodeQuality/Rector/MethodCall/AssertTrueFalseToSpecificMethodRector.php

+    private function resolveFirstArgument(FuncCall|Empty_ $firstArgumentValue): ?string
+    {
+        return $firstArgumentValue instanceof Empty_
+            ? 'empty'


@TomasVotruba this is due to removal of EmptyNameResolver PR:

[NodeNameResolver] Remove EmptyNameResolver rector-src#4782

detected after rules-tests registered to phpunit.xml

#251 (review)

samsonasik added 2 commits September 10, 2023 08:24

[CodeQuality] Skip call parent::__construct() on ConstructClassMethod…

8ecfd95

…ToSetUpTestCaseRector

init early

95018d8

register rules-tests

3d533e2

samsonasik commented Sep 10, 2023

View reviewed changes

rename fixture

fe88653

samsonasik mentioned this pull request Sep 10, 2023

[Naming] Remove matchesStringName() check completely from NodeNameResolver, including endsWith() method - use getName() and compare directly instead rectorphp/rector-src#4954

Merged

samsonasik mentioned this pull request Sep 10, 2023

BC: Separated regex matching in NodeNameResolver->isName() rectorphp/rector-src#4951

Merged

use StringUtils::isMatch

e700d52

samsonasik commented Sep 10, 2023

View reviewed changes

rules/CodeQuality/Rector/Class_/PreferPHPUnitThisCallRector.php Outdated Show resolved Hide resolved

samsonasik added 4 commits September 10, 2023 08:52

patch RemoveDataProviderTestPrefixRector

1972906

patch ReplaceTestAnnotationWithPrefixedFunctionRector

b9c5aca

patch RemoveEmptyTestMethodRector

e3b0e1c

use fnmatch

9ca5e41

samsonasik commented Sep 10, 2023

View reviewed changes

samsonasik added 4 commits September 10, 2023 09:19

remove unused imports

719d28f

skip fixture

33e7329

fix empty is not FuncCall

5e4999d

Fix AssertCallAnalyzer

8c182f2

samsonasik commented Sep 10, 2023

View reviewed changes

samsonasik added 5 commits September 10, 2023 09:41

skip indirect extends

7e389a7

cs fix

b6321ff

cs fix

5044935

current parent

ed9184e

Fixed 🎉

00a4489

samsonasik added 2 commits September 10, 2023 10:01

fix exclude source

e39796b

fix

48e1b75

samsonasik merged commit fde1cef into main Sep 10, 2023
5 checks passed

samsonasik deleted the skip-parent-construct branch September 10, 2023 03:12

samsonasik changed the title ~~[CodeQuality] Skip call parent::__construct() on ConstructClassMethodToSetUpTestCaseRector~~ [CodeQuality] Skip call parent::__construct() indirect parent on ConstructClassMethodToSetUpTestCaseRector Sep 10, 2023

samsonasik commented Sep 10, 2023

View reviewed changes

samsonasik mentioned this pull request Sep 10, 2023

[NodeNameResolver] Check regex start delimiter and contains * on NodeNameResolver to use fnmatch() rectorphp/rector-src#4964

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CodeQuality] Skip call parent::__construct() indirect parent on ConstructClassMethodToSetUpTestCaseRector #251

[CodeQuality] Skip call parent::__construct() indirect parent on ConstructClassMethodToSetUpTestCaseRector #251

samsonasik commented Sep 10, 2023 •

edited

samsonasik commented Sep 10, 2023

samsonasik Sep 10, 2023

TomasVotruba Sep 10, 2023

samsonasik commented Sep 10, 2023

samsonasik commented Sep 10, 2023

samsonasik Sep 10, 2023

samsonasik Sep 10, 2023

samsonasik commented Sep 10, 2023

samsonasik commented Sep 10, 2023

samsonasik Sep 10, 2023

[CodeQuality] Skip call parent::__construct() indirect parent on ConstructClassMethodToSetUpTestCaseRector #251

[CodeQuality] Skip call parent::__construct() indirect parent on ConstructClassMethodToSetUpTestCaseRector #251

Conversation

samsonasik commented Sep 10, 2023 • edited

samsonasik commented Sep 10, 2023

samsonasik Sep 10, 2023

Choose a reason for hiding this comment

TomasVotruba Sep 10, 2023

Choose a reason for hiding this comment

samsonasik commented Sep 10, 2023

samsonasik commented Sep 10, 2023

samsonasik Sep 10, 2023

Choose a reason for hiding this comment

samsonasik Sep 10, 2023

Choose a reason for hiding this comment

samsonasik commented Sep 10, 2023

samsonasik commented Sep 10, 2023

samsonasik Sep 10, 2023

Choose a reason for hiding this comment

samsonasik commented Sep 10, 2023 •

edited