Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cocoapods to version 1.14.3 #6475

Merged
merged 1 commit into from Feb 9, 2024
Merged

Conversation

kneth
Copy link
Member

@kneth kneth commented Feb 9, 2024

What, How & Why?

This closes # ???

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

@cla-bot cla-bot bot added the cla: yes label Feb 9, 2024
@kneth kneth merged commit d056226 into main Feb 9, 2024
3 checks passed
@kneth kneth deleted the kneth/gha/stay-on-cocoapods-1.14 branch February 9, 2024 14:34
kneth added a commit that referenced this pull request Feb 9, 2024
kneth added a commit that referenced this pull request Feb 9, 2024
@kraenhansen
Copy link
Member

kraenhansen commented Feb 13, 2024

For context, here's an issue on the RN repo tracking this: facebook/react-native#42698 and this is the issue tracked on the CocoaPods repo: CocoaPods/CocoaPods#12226 and it seems fixed in 1.15.2: CocoaPods/CocoaPods#12226 (comment)

@kraenhansen
Copy link
Member

kraenhansen commented Feb 13, 2024

I find it interesting that we were hitting this in the first place, since we do have a Gemfile.lock which already pins "cocoapods" to 1.13.0:

We should probably make sure that we run bundle install and do the pod install via bundle exec pod install as a replacement for installing a specific version of cocoapods globally.

@kraenhansen
Copy link
Member

Would you be okay with us reverting this PR? As it should now be fixed in the latest version.

# Hermes doesn't work with Cocoapods 1.15.0
# https://forums.developer.apple.com/forums/thread/745518
- name: Install older Cocoapods version
if: ${{ matrix.variant.os == 'ios') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a fix for this with ec843da

kneth added a commit that referenced this pull request Feb 27, 2024
bimusiek pushed a commit to bimusiek/realm-js that referenced this pull request Mar 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants