Skip to content

Commit

Permalink
treewide: Upgrade tokio to 1.32
Browse files Browse the repository at this point in the history
Upgrade the version of tokio we depend on to version 1.32, to get the
version with tokio-rs/tokio#5925, my fix for a
performance issue in `tokio::sync::broadcast`. We use this to notify
workers when channels are removed from the channel coordinator, so we
want this fix to improve the performance of that process.

Change-Id: Id45707e0f95ca0a76ea69952ea23e8c65f846983
  • Loading branch information
glittershark committed Aug 24, 2023
1 parent c2e5221 commit f83eda7
Show file tree
Hide file tree
Showing 4 changed files with 36 additions and 28 deletions.
58 changes: 34 additions & 24 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ postgres-native-tls = { git = "https://github.com/readysettech/rust-postgres.gi
postgres-protocol = { git = "https://github.com/readysettech/rust-postgres.git"}
postgres-types = { git = "https://github.com/readysettech/rust-postgres.git"}
tokio-postgres = { git = "https://github.com/readysettech/rust-postgres.git"}
tokio = { version = "1.28", features = ["full"] }
tokio = { version = "1.32", features = ["full"] }
rocksdb = { git = "https://github.com/readysettech/rust-rocksdb.git", default-features = false, features = ["lz4"] }

[profile.release]
Expand Down
2 changes: 1 addition & 1 deletion proptest-stateful/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ edition = "2021"
async-trait = "0.1"
proptest = "1.0.0"
rand = "0.8.5"
tokio = { version = "1.28", features = ["full"] }
tokio = { version = "1.32", features = ["full"] }

2 changes: 0 additions & 2 deletions readyset-server/src/handle.rs
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ impl Handle {
.unwrap()
.send(HandleRequest::QueryReadiness(tx))
.await
.ok()
.expect("Controller dropped, failed, or panicked");

if rx.await.unwrap() {
Expand Down Expand Up @@ -104,7 +103,6 @@ impl Handle {
done_tx: fin_tx,
})
.await
.ok()
.expect("Controller dropped, failed, or panicked");

fin_rx.await.unwrap().unwrap();
Expand Down

0 comments on commit f83eda7

Please sign in to comment.