Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1522: fix 'str' object has no attribute 'attributes' #1528

Merged
merged 4 commits into from Oct 24, 2023
Merged

Fix #1522: fix 'str' object has no attribute 'attributes' #1528

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b22a77f
Fix #1522: fix attribute error if css is str
leplatrem Sep 28, 2023
82ee56f
Revert "Fix #1522: fix attribute error if css is str"
humitos Oct 23, 2023
c4edd8b
Use `css_tag` only for standard CSS files from Sphinx
humitos Oct 23, 2023
94f173b
Normalize template variables
agjohnson Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 10 additions & 2 deletions sphinx_rtd_theme/layout.html
View file
Open in desktop
Expand Up @@ -29,11 +29,19 @@
<link rel="stylesheet" href="{{ pathto('_static/pygments.css', 1) }}" type="text/css" />
{%- endif %}
{%- for css in css_files %}
{{ css_tag(css) }}
{% if css|attr("filename") -%}
{{ css_tag(css) }}
{%- else -%}
<link rel="stylesheet" href="{{ pathto(css, 1)|escape }}" type="text/css" />
{%- endif %}
{%- endfor %}

{%- for cssfile in extra_css_files %}
humitos marked this conversation as resolved.
Show resolved Hide resolved
{{ css_tag(cssfile) }}
{% if css|attr("filename") -%}
{{ css_tag(css) }}
{%- else -%}
<link rel="stylesheet" href="{{ pathto(css, 1)|escape }}" type="text/css" />
humitos marked this conversation as resolved.
Show resolved Hide resolved
{%- endif %}
{%- endfor -%}

{#- FAVICON
Expand Down