Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1522: fix 'str' object has no attribute 'attributes' #1528

Merged
merged 4 commits into from Oct 24, 2023
Merged

Fix #1522: fix 'str' object has no attribute 'attributes' #1528

merged 4 commits into from Oct 24, 2023

Conversation

leplatrem
Copy link
Contributor

Fix #1522

@leplatrem leplatrem requested a review from a team as a code owner September 28, 2023 11:19
@leplatrem leplatrem mentioned this pull request Sep 28, 2023
Closed
@agjohnson
Copy link
Collaborator

Thanks for the fix here @leplatrem !

This was recently changed, in #1519, though it wasn't clear if there was going to be any side effects from the change. I guess there are side effects, which isn't too surprising.

This is reverting to what we had before, so should definitely be safe. But I will first try to understand what is happening in #1522, or why the css_tag fails here. It was my understanding the css_tag call would be safer, but I'm guessing it comes down to the Sphinx configuration.

I'll want to aim to merge this in, reverting that change, before next week. I'm planning on a 2.0 final release on Monday or Tues.

@agjohnson agjohnson modified the milestones: 2.0, 2.1 Sep 28, 2023
@leplatrem
Copy link
Contributor Author

Excellent, thank you! 💚

agjohnson
agjohnson approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is revert to the old logic, it should be okay. If I don't come up with another fix or reason to keep the current logic, I'll look to merge this early next week for the 2.0 release. We can revisit the reverted change again in another release if we need.

mitya57
mitya57 reviewed Sep 30, 2023
View reviewed changes
sphinx_rtd_theme/layout.html Outdated Show resolved Hide resolved
sphinx_rtd_theme/layout.html Outdated Show resolved Hide resolved
@mitya57 mitya57 mentioned this pull request Oct 10, 2023
Closed
@humitos
Revert "Fix readthedocs#1522: fix attribute error if css is str"
82ee56f 
This reverts commit b22a77f.
@humitos
Use css_tag only for standard CSS files from Sphinx
c4edd8b 
... and keep using the custom `link` HTML tag for CSS files included via the
HTML theme option `extra_css_files`.
@humitos
Copy link
Member

humitos commented Oct 23, 2023

I updated this PR to take into consideration the review comments from @mitya57. It should work for all the Sphinx versions we support now. I'd be happy to merge this PR and release a new rc version to PyPI so people can continue testing it.

@mitya57
Copy link
Contributor

mitya57 commented Oct 23, 2023

This looks good to me now. 👍

agjohnson
agjohnson approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix looks good to me, I'll get an RC prepared this afternoon so we can test the fix further.

I pushed up a change just standardizing the variable names, will wait on that.

humitos
humitos approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@agjohnson agjohnson merged commit 32310a8 into readthedocs:master Oct 24, 2023
8 checks passed
@agjohnson
Copy link
Collaborator

2.0.0rc3 is now out with this fix. Thanks everyone!

@mitya57 mitya57 mentioned this pull request Oct 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitya57 mitya57 mitya57 left review comments

@humitos humitos humitos approved these changes

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Error with 2.0.0rc2: AttributeError("'str' object has no attribute 'attributes'")
4 participants
@leplatrem @agjohnson @humitos @mitya57