feat: add removeAllFalsy option #128
Conversation
src/index.ts
Outdated
| @@ -6,30 +6,43 @@ function isEmptyObject(obj: unknown) { | |||
| return typeof obj === 'object' && obj !== null && !Object.keys(obj).length; | |||
| } | |||
|
|
|||
| export interface RemovalOptions { | |||
There was a problem hiding this comment.
Having a default and secondary export in the same file gets really messy in CJS dist builds, causing types to get screwed up, do you mind either not exporting this or moving it to a separate file and exposing that in the exports config?
remove-undefined-objects/package.json
Lines 8 to 14 in cbe07a7
We have a custom ESLint plugin that has the rule that's being flagged for this case below. There's some more details about why it can be problematic here.
There was a problem hiding this comment.
👍 I removed the second export and filed readmeio/standards#919. Thanks for the tip!
|
Published to v6.0.0, thanks again! https://github.com/readmeio/remove-undefined-objects/releases/tag/6.0.0 |
🧰 Changes
Adds and documents an optional
removeAllFalsyflag in a new optional options object. If true,''andnullwill also be removed from objects.🧬 QA & Testing
I added unit tests and ran them.