Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix doc title displayed as untitled #4008

Merged
merged 1 commit into from
Mar 10, 2025
Merged

fix doc title displayed as untitled #4008

merged 1 commit into from
Mar 10, 2025
+24 −24

Conversation

dev-jonghoonpark
Copy link
Contributor

Fix issue #4006

@dev-jonghoonpark dev-jonghoonpark requested a review from a team as a code owner March 7, 2025 15:39
@chemicL chemicL changed the base branch from main to 3.7.x March 10, 2025 13:32
@chemicL chemicL changed the base branch from 3.7.x to main March 10, 2025 13:32
@chemicL
Copy link
Member

chemicL commented Mar 10, 2025

Thanks. Would you mind rebasing this change on top of 3.7.x branch so that we can include the fixes into the current released version and not just the future release (main)?

@chemicL chemicL added the type/documentation A documentation update label Mar 10, 2025
@dev-jonghoonpark
Copy link
Contributor Author

@chemicL
Sure, that's possible! Just to confirm, should I create a new PR with the changes rebased onto the 3.7.x branch?

@chemicL
Copy link
Member

chemicL commented Mar 10, 2025

You could just use git rebase --onto, force push to your branch and change the base of this PR.

@dev-jonghoonpark
fix doc title displayed as untitled
Loading
Loading status checks…
c8928a9 
Signed-off-by: dev-jonghoonpark <dev@jonghoonpark.com>
@dev-jonghoonpark dev-jonghoonpark force-pushed the 4006-fix-doc-title-displayed-as-untitled branch from 9c83cac to c8928a9 Compare March 10, 2025 13:54
@dev-jonghoonpark
Copy link
Contributor Author

Thank you for your guidance.
As per your instructions, I performed the rebase and force push.
Could you please check if everything is correct?

@chemicL chemicL changed the base branch from main to 3.7.x March 10, 2025 14:01
@chemicL chemicL added this to the 3.7.4 milestone Mar 10, 2025
@chemicL chemicL merged commit 65e6b4e into reactor:3.7.x Mar 10, 2025
9 checks passed
chemicL added a commit that referenced this pull request Mar 10, 2025
@chemicL
Merge #4008 into 3.8.0-M1
Loading
Loading status checks…
5636614
@chemicL
Copy link
Member

chemicL commented Mar 10, 2025

Thank you for the contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemicL chemicL

Assignees
No one assigned
Labels
type/documentation A documentation update
Projects
None yet
Milestone
3.7.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dev-jonghoonpark @chemicL