Allowing Blocking call for handlePossibleCancellationInterrupt #3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chemicL
reviewed
Jun 23, 2023
...or-core/src/blockHoundTest/java/reactor/core/scheduler/ReactorBlockHoundIntegrationTest.java
Outdated
Show resolved
Hide resolved
OlegDokuka
approved these changes
Jun 26, 2023
OlegDokuka
suggested changes
Jun 26, 2023
|
@OlegDokuka I have reverted the test changes. |
OlegDokuka
reviewed
Jun 29, 2023
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2019-2022 VMware Inc. or its affiliates, All Rights Reserved. | |||
There was a problem hiding this comment.
this should also be reverted
There was a problem hiding this comment.
Thanks @OlegDokuka reverted this change
OlegDokuka
reviewed
Jun 29, 2023
| @@ -50,5 +50,7 @@ public void applyTo(BlockHound.Builder builder) { | |||
| // For now, let's not add a separate integration, but rather let's define the class name manually | |||
| // ContextRegistry reads files as part of the Service Loader aspect. If class is initialized in a non-blocking thread, BlockHound would complain | |||
| builder.allowBlockingCallsInside("reactor.core.publisher.ContextPropagation", "<clinit>"); | |||
| builder.allowBlockingCallsInside("java.util.concurrent.FutureTask", | |||
There was a problem hiding this comment.
use FutureTask.class.getName() instead of "java.util.concurrent.FutureTask"
There was a problem hiding this comment.
Update with class reference
OlegDokuka
approved these changes
Jun 29, 2023
This reverts commit c7cdc0a.
|
I've made required changes. @OlegDokuka please check |
OlegDokuka
approved these changes
Jun 30, 2023
|
@tejavenkatlanka great job! Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixs #3512