Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thread interrupt state propagate (#3451) #3482

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

10sa
Copy link
Contributor

@10sa 10sa commented May 31, 2023

Fix interrupt state not being propagated when interrupted while thread is in wait state by calling blocking method

Fixes #3451

@10sa 10sa requested a review from a team as a code owner May 31, 2023 11:57
@pivotal-cla
Copy link

@10sa Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

1 similar comment
@pivotal-cla
Copy link

@10sa Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@10sa Thank you for signing the Contributor License Agreement!

@OlegDokuka
Copy link
Contributor

@10sa welcome on board & great work! Can you please rebase this PR on 3.4.x branch and change the target from main to 3.4.x

@OlegDokuka OlegDokuka added the type/enhancement A general enhancement label Jun 7, 2023
@OlegDokuka OlegDokuka added this to the 3.4.30 milestone Jun 7, 2023
@10sa 10sa changed the base branch from main to 3.4.x June 8, 2023 09:54
@10sa
Copy link
Contributor Author

10sa commented Jun 8, 2023

Yup, I'll change the target branch first, and I'll get a new branch with the 3.4.x version soon, and then force push with my commits.

Fix interrupt state not being propagated when interrupted while thread is in wait state by calling blocking method

Fixes reactor#3451

Signed-off-by: Kim Jae Hwan <zenkins52@gmail.com>
@10sa
Copy link
Contributor Author

10sa commented Jun 8, 2023

On my PC, some unit tests report failure when running gradle check. However, the 3.4.x branch also fails the unit test.

I don't know the cause, I've completed the rebase work for now.

@violetagg violetagg modified the milestones: 3.4.30, 3.4.31 Jun 13, 2023
@OlegDokuka OlegDokuka merged commit 19ca826 into reactor:3.4.x Jun 21, 2023
6 checks passed
@reactorbot
Copy link

@OlegDokuka this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to main 🙇

@OlegDokuka
Copy link
Contributor

@10sa good work! Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interrupt state not propagated when Thread interrupted during Blocking method call
5 participants