Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update retryWhen docs on deprecated currentContext #3283

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Update retryWhen docs on deprecated currentContext #3283

merged 1 commit into from
Jun 21, 2023

Conversation

cbrunsdon
Copy link
Contributor

This should now be pointing to contextView as currentContext is deprecated

@pivotal-cla This is an Obvious Fix

@cbrunsdon cbrunsdon requested a review from a team as a code owner November 16, 2022 01:42
simonbasle
simonbasle requested changes Nov 16, 2022
View reviewed changes
Copy link
Member

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch ! I think there are other places where a similar change could be implemented, notably the FluxSink and MonoSink javadocs deprecation notice for currentContext().

also, the notices and deprecations have been put as early as the 3.4.x branch. would you mind retargetting your PR to that branch instead? 🙇

@cbrunsdon cbrunsdon force-pushed the retrywhen_current_context_deprecated branch from 2f7a89e to 5e8d2d1 Compare November 16, 2022 17:42
@cbrunsdon cbrunsdon changed the base branch from main to 3.4.x November 16, 2022 17:42
@cbrunsdon cbrunsdon changed the base branch from 3.4.x to main November 16, 2022 17:42
@cbrunsdon
Update retryWhen docs on deprecated currentContext
10bcd2d 
This should now be pointing to contextView as currentContext is
deprecated
@cbrunsdon cbrunsdon force-pushed the retrywhen_current_context_deprecated branch from 5e8d2d1 to 10bcd2d Compare November 16, 2022 17:43
@cbrunsdon cbrunsdon changed the base branch from main to 3.4.x November 16, 2022 17:44
@cbrunsdon
Copy link
Contributor Author

cbrunsdon commented Nov 16, 2022 •
edited

Retargetted to 3.4 and picked up the other two instances, thanks.

Couldn't find anything else wrongly referencing getContextView, all remaining instances (on the 3.4.x branch anyway) are for the Signal method.

@OlegDokuka OlegDokuka merged commit 6f05d02 into reactor:3.4.x Jun 21, 2023
@reactorbot
Copy link

@OlegDokuka this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to main 🙇

OlegDokuka added a commit that referenced this pull request Jun 21, 2023
@OlegDokuka
Merge #3283 branch 3.5.8
c04805a 
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
@OlegDokuka
Copy link
Contributor

@cbrunsdon great work! Thanks for your improvements!

@chemicL chemicL added the type/documentation A documentation update label Jul 12, 2023
@chemicL chemicL modified the milestones: 3.4.32, 3.4.31 Jul 12, 2023
This was referenced Sep 13, 2023
Open
Open
Open
Open
@renovate renovate bot mentioned this pull request Nov 16, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegDokuka OlegDokuka OlegDokuka approved these changes

@simonbasle simonbasle Awaiting requested review from simonbasle

Assignees
No one assigned
Labels
type/documentation A documentation update
Projects
None yet
Milestone
3.4.31
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cbrunsdon @reactorbot @OlegDokuka @simonbasle @chemicL