Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support document.activeElement #360

Conversation

AnathanPham
Copy link

@AnathanPham AnathanPham commented Mar 10, 2023

支持document.activeElement获取到dialog组件的内容,而不是一个空的div。
ant-design/ant-design#40380

使用一个div包裹dialog组件的内容,并使div聚焦,从而使div包含内容,而不是一个空的div。

@vercel
Copy link

vercel bot commented Mar 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
dialog ❌ Failed (Inspect) Mar 10, 2023 at 0:05AM (UTC)

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #360 (3ce0652) into master (646efc7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 3ce0652 differs from pull request most recent head 13f70e4. Consider uploading reports for the commit 13f70e4 to get more accurate results

@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
+ Coverage   98.12%   98.14%   +0.02%     
==========================================
  Files           7        7              
  Lines         160      162       +2     
  Branches       50       50              
==========================================
+ Hits          157      159       +2     
  Misses          2        2              
  Partials        1        1              
Impacted Files Coverage Δ
src/Dialog/Content/Panel.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wahiche-ideal
Copy link
Contributor

Is this update ever going to get redeployed? Seems like it will fix an issue that will greatly improve the a11y of antD. It has been sitting idle for almost 1 year.

@afc163
Copy link
Member

afc163 commented Jan 16, 2024

Conflicting

@wahiche-ideal
Copy link
Contributor

What does conflicting even mean? There are merge conflicts?

@yoyo837
Copy link
Member

yoyo837 commented Jan 17, 2024

What does conflicting even mean? There are merge conflicts?

Rebase please

@afc163
Copy link
Member

afc163 commented Jan 17, 2024

图片

@wahiche-ideal
Copy link
Contributor

@AnathanPham you were the one who originally made this change, I am not sure how to fix the conflict, is this something that you can do? Maybe get this fix pushed?

@wahiche-ideal
Copy link
Contributor

Because this has been sitting stale for a while I have forked the fix by @AnathanPham and fixed issues with the index.spec.tsx. You can see the new PR here. #393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants