Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add afterOpenChange prop #349

Merged
merged 4 commits into from
Mar 1, 2023
Merged

Conversation

MuxinFeng
Copy link
Contributor

@MuxinFeng MuxinFeng commented Feb 21, 2023

@vercel
Copy link

vercel bot commented Feb 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
dialog ❌ Failed (Inspect) Feb 28, 2023 at 10:58AM (UTC)

@MuxinFeng
Copy link
Contributor Author

close #251

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #349 (cb40762) into master (fd1e6f1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head cb40762 differs from pull request most recent head 3bd603f. Consider uploading reports for the commit 3bd603f to get more accurate results

@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   98.73%   98.74%           
=======================================
  Files           7        7           
  Lines         158      159    +1     
  Branches       49       49           
=======================================
+ Hits          156      157    +1     
  Misses          1        1           
  Partials        1        1           
Impacted Files Coverage Δ
src/Dialog/index.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/Dialog/index.tsx Outdated Show resolved Hide resolved
Co-authored-by: afc163 <afc163@gmail.com>
@MuxinFeng
Copy link
Contributor Author

这块跑 prettier 改动还蛮大的,就暂时吧 prettier 管了;
后续有需要的话,可以单独跑一下?

@MadCcc
Copy link
Member

MadCcc commented Feb 22, 2023

这块跑 prettier 改动还蛮大的,就暂时吧 prettier 管了; 后续有需要的话,可以单独跑一下?

需要升级一下 father 了,用 lint-staged 就不会检查其他文件

@MuxinFeng
Copy link
Contributor Author

这块跑 prettier 改动还蛮大的,就暂时吧 prettier 管了; 后续有需要的话,可以单独跑一下?

需要升级一下 father 了,用 lint-staged 就不会检查其他文件

好嘞,father 升级我另开个 pr 吧

@MadCcc
Copy link
Member

MadCcc commented Feb 22, 2023

这块跑 prettier 改动还蛮大的,就暂时吧 prettier 管了; 后续有需要的话,可以单独跑一下?

需要升级一下 father 了,用 lint-staged 就不会检查其他文件

好嘞,father 升级我另开个 pr 吧

rc-test 有自动升级脚本,father 4 去掉了内置的 husky,所以需要手动安装一下

@MuxinFeng
Copy link
Contributor Author

MuxinFeng commented Feb 22, 2023

这块跑 prettier 改动还蛮大的,就暂时吧 prettier 管了; 后续有需要的话,可以单独跑一下?

需要升级一下 father 了,用 lint-staged 就不会检查其他文件

好嘞,father 升级我另开个 pr 吧

rc-test 有自动升级脚本,father 4 去掉了内置的 husky,所以需要手动安装一下

大佬,我按照 re-menu 升级的 pr 和 father 升级指南看了下,目前还有问题,似乎还需要自己安装 husky 并且配置 pre-commit 才能提交,但是我看其他 rc 项目并没有做这些配置。

@MuxinFeng MuxinFeng changed the title feat: add onOpenChanged prop feat: add onOpenChange prop Feb 23, 2023
@MuxinFeng MuxinFeng changed the title feat: add onOpenChange prop feat: add afterOpenChange prop Feb 28, 2023
@MuxinFeng
Copy link
Contributor Author

结合原 issue 下的提示,按照 rc-drawer 的 api 定义方式重新修改了下,还是 afterOpenChange 更合适。

@MuxinFeng
Copy link
Contributor Author

相关 issue:

  1. 与本 pr 重复,且存在冲突,可以关闭了 feat: add afterOpen prop #251
  2. comment 提到的升级 father、rc-test 依赖,是对照 rc-menu 做的,求瞅瞅 chore: father4 & rc-test #350
  3. antd 中对本次新增 prop 的说明 feat(Modal): add onOpenChange prop ant-design/ant-design#40852

@MadCcc MadCcc merged commit 08da1bf into react-component:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Modal] 对话框希望增加一个切换动画结束后的回调
3 participants