Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH Actions: minor tweaks #72

Merged
merged 2 commits into from
Mar 20, 2023
Merged

GH Actions: minor tweaks #72

merged 2 commits into from
Mar 20, 2023

Commits on Mar 20, 2023

  1. GH Actions: minor tweak 

    Since Composer 2.2.0, the `--ignore-platform-reqs` setting can be made more specific.

By using `--ignore-platform-req=php+` instead of `--ignore-platform-reqs`, only the upper bound for PHP platform requirements will be ignored, not _all_ platform requirements.

Ref: https://blog.packagist.com/composer-2-2/#-ignore-platform-req-improvements
    @jrfnl
    jrfnl committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    a829c57 View commit details
    Browse the repository at this point in the history

  2. GH Actions: harden the workflow against PHPCS ruleset errors 

    If there is a ruleset error, the `cs2pr` action doesn't receive an `xml` report and exits with a `0` error code, even though the PHPCS run failed (though not on CS errors, but on a ruleset error).

This changes the GH Actions workflow to allow for that situation and still fail the build in that case.
    @jrfnl
    jrfnl committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    89c901b View commit details
    Browse the repository at this point in the history