Composer: controlled update of CS dependencies #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is used by the DMS Coding Standard to register external PHPCS standards with PHPCS. As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run. This adds the necessary configuration for that. Refs: * https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
The `squizlabs/php_codesniffer` package is a dependency of the `dms/coding-standard` package, not of **_this_** package. Better to let the `dms/coding-standard` package (and its dependencies) manage the minimum require PHPCS version.
... without changing the version constraints.
Merged
rdohms
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer: allow the PHPCS plugin
The
dealerdirect/phpcodesniffer-composer-installerComposer plugin is used by the DMS Coding Standard to register external PHPCS standards with PHPCS.As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run. This adds the necessary configuration for that.
Refs:
Composer: remove explicit PHPCS dependency
The
squizlabs/php_codesnifferpackage is a dependency of thedms/coding-standardpackage, not of this package.Better to let the
dms/coding-standardpackage (and its dependencies) manage the minimum require PHPCS version.Composer: controlled update of CS dependencies
... without changing the version constraints.