Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] Cache expensive calls to inspect.signature #49975

Merged
merged 7 commits into from
Jan 20, 2025
Merged

[serve] Cache expensive calls to inspect.signature #49975

merged 7 commits into from
Jan 20, 2025
+63 −33

Conversation

edoakes
Copy link
Collaborator

@edoakes edoakes commented Jan 20, 2025

Why are these changes needed?

Discovered in profiling that this call is quite expensive. Cached the call and added a convenient wrapper dataclass for methods + their metadata.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Sorry, something went wrong.

@edoakes
fix

Verified

This commit was signed with the committer’s verified signature.
mskelton Mark Skelton
SSH Key Fingerprint: H6YUF5oa/6RtojzPU4CuXQzRxLf+We99GPwDtwc5ZXE
Verified
Learn about vigilant mode
3c08fbc 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
fix
Loading
Loading status checks…
3523d5e 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes requested review from zcin and GeneDer January 20, 2025 17:51
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Jan 20, 2025
@edoakes
fix

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
44e60e6 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
fix

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
Loading
Loading status checks…
c86d92d 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
fix

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
Loading
Loading status checks…
2c6d9be 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
GeneDer
GeneDer approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@edoakes edoakes enabled auto-merge (squash) January 20, 2025 19:01
@edoakes
fix

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
Loading
Loading status checks…
524ddff 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@github-actions github-actions bot disabled auto-merge January 20, 2025 19:48
@edoakes
Merge branch 'master' of https://github.com/ray-project/ray into eoak…

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
Loading
Loading status checks…
61d033e 
…es/cache-inspect
@edoakes edoakes enabled auto-merge (squash) January 20, 2025 19:48
@edoakes edoakes merged commit cd97fb1 into ray-project:master Jan 20, 2025
6 checks passed
anson627 pushed a commit to anson627/ray that referenced this pull request Jan 31, 2025
@edoakes @anson627
[serve] Cache expensive calls to inspect.signature (ray-project#49975)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
50a7a77 
Discovered in profiling that this call is quite expensive. Cached the
call and added a convenient wrapper dataclass for methods + their
metadata.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Anson Qian <anson627@gmail.com>
srinathk10 pushed a commit that referenced this pull request Feb 2, 2025
@edoakes @srinathk10
[serve] Cache expensive calls to inspect.signature (#49975)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
60aa916 
Discovered in profiling that this call is quite expensive. Cached the
call and added a convenient wrapper dataclass for methods + their
metadata.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
anyadontfly pushed a commit to anyadontfly/ray that referenced this pull request Feb 13, 2025
@edoakes @anyadontfly
[serve] Cache expensive calls to inspect.signature (ray-project#49975)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
5572fc4 
Discovered in profiling that this call is quite expensive. Cached the
call and added a convenient wrapper dataclass for methods + their
metadata.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Puyuan Yao <williamyao034@gmail.com>
park12sj pushed a commit to park12sj/ray that referenced this pull request Mar 18, 2025
@edoakes @park12sj
[serve] Cache expensive calls to inspect.signature (ray-project#49975)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
7ed25b3 
Discovered in profiling that this call is quite expensive. Cached the
call and added a convenient wrapper dataclass for methods + their
metadata.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeneDer GeneDer

@zcin zcin

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edoakes @GeneDer