[core] Add metrics ray_io_context_event_loop_lag_ms. #47989
Merged
+118
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
rynewang
force-pushed
the
ioctx-lag-metrics
branch
from
7f144ed to
97191d8
Compare
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
|
@MengjinYan could you review the PR. This is related to observability. |
rynewang
commented
Oct 12, 2024
MengjinYan
reviewed
Oct 15, 2024
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
MengjinYan
approved these changes
Oct 24, 2024
jjyao
reviewed
Oct 25, 2024
| @@ -145,6 +145,12 @@ DEFINE_stats(placement_groups, | |||
| /// ===================== INTERNAL SYSTEM METRICS ================================= | |||
| /// =============================================================================== | |||
|
|
|||
| DEFINE_stats(io_context_event_loop_lag_ms, | |||
| "Latency of a task from post to execution", | |||
There was a problem hiding this comment.
This is basically the queuing time we print in the debug state right?
There was a problem hiding this comment.
I think so. just that one does not have a metrics and we don't always want to look at logs.
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
jjyao
approved these changes
Oct 28, 2024
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
Adds a metric to monitor event loop lag for `instrumented_io_context`. This is by default applied to IO Contexts in GCS only. By default every 250ms we post an async task and use std::chrono::steady_clock to record the lag. The metric is a GAUGE with the thread name recorded. I tested this on my laptop and it works - it's a ~0 on an idle cluster, and 1000ms if I use `RAY_testing_asio_delay_us=event_loop_lag_probe=1000000:1000000`. Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
Adds a metric to monitor event loop lag for `instrumented_io_context`. This is by default applied to IO Contexts in GCS only. By default every 250ms we post an async task and use std::chrono::steady_clock to record the lag. The metric is a GAUGE with the thread name recorded. I tested this on my laptop and it works - it's a ~0 on an idle cluster, and 1000ms if I use `RAY_testing_asio_delay_us=event_loop_lag_probe=1000000:1000000`. Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
Adds a metric to monitor event loop lag for `instrumented_io_context`. This is by default applied to IO Contexts in GCS only. By default every 250ms we post an async task and use std::chrono::steady_clock to record the lag. The metric is a GAUGE with the thread name recorded. I tested this on my laptop and it works - it's a ~0 on an idle cluster, and 1000ms if I use `RAY_testing_asio_delay_us=event_loop_lag_probe=1000000:1000000`. Signed-off-by: Ruiyang Wang <rywang014@gmail.com> Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a metric to monitor event loop lag for
instrumented_io_context. This is by default applied to IO Contexts in GCS only.By default every 250ms we post an async task and use std::chrono::steady_clock to record the lag. The metric is a GAUGE with the thread name recorded.
I tested this on my laptop and it works - it's a ~0 on an idle cluster, and 1000ms if I use
RAY_testing_asio_delay_us=event_loop_lag_probe=1000000:1000000.