fix(doc): do not access deprecated Cell::symbol field in doc example
#626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysd
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka and
kdheepak
as code owners
orhun
approved these changes
Nov 12, 2023
joshka
approved these changes
Nov 13, 2023
|
Hey, would you mind signing your commit? |
|
Ah, I forgot signing after rebasing the branch. I'll do it tonight. |
Signed-off-by: rhysd <lin90162@yahoo.co.jp>
rhysd
force-pushed
the
fix-doc-example
branch
from
d5f98db
to
35082c9
Compare
|
@joshka I updated my commit. |
|
Thanks @rhysd :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed one doc example still accessed
Cell::symbolfield deprecated at #624.cargo test --docdoesn't show any warnings.cargo clippydoesn't check doc examples. So I didn't notice it. This PR fixes the example.