Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(buffer): deprecate Cell::symbol field #624

Merged
merged 2 commits into from Nov 12, 2023

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Nov 11, 2023

This PR deprecates accessing Cell::symbol field following the discussion at #601.

  1. Add deprecation message on Cell::symbol field and getter API for the field
  2. Release ratatui v0.24.1 (or v0.24.2 if v0.24.1 doesn't fit)
  3. Hide the symbol field
  4. Release the change at v0.25.0

This PR does the step 1. assuming to be included in v0.24.1.

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #624 (6a52360) into main (df0eb1f) will increase coverage by 0.0%.
The diff coverage is 88.0%.

@@          Coverage Diff          @@
##            main    #624   +/-   ##
=====================================
  Coverage   90.4%   90.4%           
=====================================
  Files         41      41           
  Lines      11890   11903   +13     
=====================================
+ Hits       10758   10771   +13     
  Misses      1132    1132           
Files Coverage Δ
src/backend/termion.rs 26.7% <100.0%> (ø)
src/backend/test.rs 97.7% <100.0%> (ø)
src/widgets/canvas/line.rs 99.5% <100.0%> (ø)
src/backend/crossterm.rs 0.0% <0.0%> (ø)
src/backend/termwiz.rs 0.0% <0.0%> (ø)
src/buffer.rs 96.8% <94.4%> (+<0.1%) ⬆️

Signed-off-by: rhysd <lin90162@yahoo.co.jp>
Copy link
Sponsor Member

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/buffer.rs Outdated Show resolved Hide resolved
Signed-off-by: rhysd <lin90162@yahoo.co.jp>
@joshka joshka merged commit edacaf7 into ratatui-org:main Nov 12, 2023
32 of 33 checks passed
@joshka
Copy link
Member

joshka commented Nov 12, 2023

Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants